params: Fix regression

The first parameter to Object.assign() is the same target object that
will be returned. That is, since commit 46874eed0 Params.parse() modifies
the @defaults object. Usually we pass that parameter as an object literal
and this isn't an issue, but the change breaks spectacularly in the few
cases where we use a re-usable variable.

Restore the previous behavior by copying the object first.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/615

diff --git a/js/misc/params.js b/js/misc/params.js
index 0e3af95323610437f55930dec7b42ffce7bd9c99..6878395e93480ef2e2728fc05f670696d45caa63 100644 (file)
--- a/js/misc/params.js
+++ b/js/misc/params.js
@@ -1,5 +1,7 @@
 // -*- mode: js; js-indent-level: 4; indent-tabs-mode: nil -*-
 
+const Lang = imports.lang;
+
 // parse:
 // @params: caller-provided parameter object, or %null
 // @defaults-provided defaults object
@@ -21,5 +23,7 @@ function parse(params = {}, defaults, allowExtras) {
                 throw new Error(`Unrecognized parameter "${prop}"`);
     }
 
-    return Object.assign(defaults, params);
+    let defaultsCopy = {};
+    Lang.copyProperties(defaults, defaultsCopy);
+    return Object.assign(defaultsCopy, params);
 }